Skip to content

landroid.js.org #9958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2025
Merged

landroid.js.org #9958

merged 3 commits into from
Jul 16, 2025

Conversation

lll69
Copy link
Contributor

@lll69 lll69 commented Jul 14, 2025

The site content is at https://github.com/lll69/landroid-web

MattIPv4
MattIPv4 requested changes Jul 14, 2025
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Please could you explain how this is related directly to the JavaScript ecosystem/community? Why is this something a JavaScript developer specifically would use more-so than anyone else?

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Jul 14, 2025
@lll69
Copy link
Contributor Author

lll69 commented Jul 15, 2025

This project is a JS/TS adaptation of the original Android project, using HTML Canvas. The main logic of the project is in the src/ folder.

@MattIPv4
Copy link
Member

Okay... but how is this directly relevant to the JS ecosystem/community? Why is this something a JS developer would use more-so than anyone else? It seems to just be a game built with JS, which tends to be how most games on the web are built...

@lll69
Copy link
Contributor Author

lll69 commented Jul 15, 2025

The original project was written in Kotlin, I changed it to TypeScript and added some code adapted from Kotlin, including Deque and XorWowRandom.

@indus
Copy link
Member

indus commented Jul 15, 2025

@MattIPv4 I tend to accept it as a tech demo of less common JS usage with a link to the source code and an opportunity to learn from it... I hope that is ok for you.

@lll69
I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line landroid.js.org to make it work.

In case you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

I'll merge after we have "contact". Please keep this PR open.

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain and removed awaiting response This PR is waiting for a response from the requester labels Jul 15, 2025
@MattIPv4 MattIPv4 changed the title landroid-web.js.org landroid.js.org Jul 16, 2025
@lll69
Copy link
Contributor Author

lll69 commented Jul 16, 2025

Added CNAME

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Jul 16, 2025
@indus
Copy link
Member

indus commented Jul 16, 2025

Welcome https://landroid.js.org

@indus indus merged commit cd1d44f into js-org:master Jul 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lll69 @MattIPv4 @indus